Skip to content

Deleting unecessary API#134

Merged
apichery merged 2 commits into
release/9.0from
fix/dss-90-jupyter-api-rm
Mar 30, 2021
Merged

Deleting unecessary API#134
apichery merged 2 commits into
release/9.0from
fix/dss-90-jupyter-api-rm

Conversation

@pbailly

@pbailly pbailly commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@pbailly pbailly requested a review from apichery March 30, 2021 09:18
@pbailly pbailly self-assigned this Mar 30, 2021
@apichery apichery added this to the 9.0.1 milestone Mar 30, 2021
@sourcery-ai

sourcery-ai Bot commented Mar 30, 2021

Copy link
Copy Markdown

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.43%.

Quality metrics Before After Change
Complexity 1.73 ⭐ 1.53 ⭐ -0.20 👍
Method Length 26.69 ⭐ 26.18 ⭐ -0.51 👍
Working memory 7.97 🙂 7.94 🙂 -0.03 👍
Quality 81.22% 81.65% 0.43% 👍
Other metrics Before After Change
Lines 949 927 -22
Changed files Quality Before Quality After Quality Change
dataikuapi/dssclient.py 81.22% ⭐ 81.65% ⭐ 0.43% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
dataikuapi/dssclient.py DSSClient.create_meaning 6 ⭐ 119 🙂 14 😞 53.96% 🙂 Extract out complex expressions
dataikuapi/dssclient.py DSSClient.sql_query 1 ⭐ 60 ⭐ 20 ⛔ 61.62% 🙂 Extract out complex expressions
dataikuapi/dssclient.py DSSClient._perform_http 5 ⭐ 94 🙂 11 😞 62.98% 🙂 Extract out complex expressions
dataikuapi/dssclient.py DSSClient.create_code_env 3 ⭐ 78 🙂 13 😞 63.96% 🙂 Extract out complex expressions
dataikuapi/dssclient.py DSSClient.create_cluster 3 ⭐ 88 🙂 11 😞 65.80% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@apichery apichery merged commit c39d1ab into release/9.0 Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants